[FFmpeg-devel] lavfi noise generator
Mon Dec 29 13:45:23 CET 2008
On Mon, Dec 29, 2008 at 11:39:30AM +0100, Stefano Sabatini wrote:
> On date Monday 2008-12-29 00:52:18 +0100, Michael Niedermayer encoded:
> > On Mon, Dec 29, 2008 at 12:25:02AM +0100, Stefano Sabatini wrote:
> > > Hi all,
> > >
> > > no Michael I'm not posting it for you or others to review it, I'm just
> > no but i reject it anyway
> > your code is crap, sorry
> > People didnt want to port libmpcodecs when i suggested it, i dont mind
> > this at all, libmpcodecs has its serious issues but this does not mean i
> > will accept code that is inferrior than it.
> > vf_noise.c should be MUCH faster than your code.
> As for the speed concerns, I see two major issues to be addressed, the
> use of the av_random() for setting every single byte, ideally we
> should set the whole buffer for example reading from /dev/urandom but
> this would not be portable, and the av_picture_copy() can be avoided
> using properly the permissions system and passing a picture reference.
did you read vf_noise.c ?
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I wish the Xiph folks would stop pretending they've got something they
do not. Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel