[FFmpeg-devel] [PATCH] fix crash in ffplay.c #2

[Michael Niedermayer]

On Mon, Dec 29, 2008 at 07:54:26PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Dec 29, 2008 at 7:33 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > This is certainly not a correct fix ...
> > And its hard to say how to fix it without any clue about the kind of
> > file you try to play, or why channels are not set.
> 
> It's the file provided by Jai in the thread "[FFmpeg-devel] [PATCH]
> fix crash in realmedia demuxer". The file is a multirate-.rm file,
> i.e. some tracks only start several MB into the file, I think there's
> a filesize limit in av_find_stream_info(). anyway, that's practical,
> in theory there's many reasons why av_find_stream_info() could fail to
> find stream info for some tracks.

yes, and ffplay.c should be fixed not to use tracks that lack essential
information but not to salt the code with
if(X==0) //it 0 was, me add to crash prevent
iam really allergic to these kind of "fixes"

besides of course rm*.c should be fixed to support non interleaved rm.


> 
> I know the fix isn't correct, just trying to describe the problem and
> hope someone will make this hack unnecessary in my local tree.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081230/6950b70a/attachment.pgp>