[FFmpeg-devel] [PATCH]Improved message for bitrate tolerance too small
Fri Feb 1 11:01:17 CET 2008
Michael Niedermayer wrote:
> On Thu, Jan 31, 2008 at 04:26:57PM +0100, Michel Bardiaux wrote:
>>> Note that if someone could explain *why* tol must be > bitrate/fps...
> IIRC the test is a heuristic, thus the minimum the patch would print isnt much
> better than 2* of that or 0.5* of it. Values that small cause problems.
> So i dont want to make it easy to select the smallest value, because that
> is almost certainly too small.
Does that mean you forbid the patch? Because as things stand, we have an
error condition that can be understood only by looking in the code, talk
about obfuscated behaviour...
Besides I have another issues with the current code: It is
mathematically very dubious since it compares a bitrate*timebase with a
T +32  2 790 29 41
F +32  2 790 29 02
E mailto:mbardiaux at mediaxim.be
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
More information about the ffmpeg-devel