[FFmpeg-devel] [PATCH] miscelleneous NUT fixes

Michael Niedermayer michaelni
Sat Feb 2 18:41:20 CET 2008

On Sat, Feb 02, 2008 at 06:18:33PM +0200, ods15 at ods15.dyndns.org wrote:
> Some fixed for the lavf NUT demuxer/muxer:

First, all of these MUST be seperate commits, and should have been seperate

> muxer
> 1. nut->max_distance was not set at all anywhere in the muxer


> 2. I assume the syncpoint positioning was meant to be "put if this is a 
> keyframe, and the last frame was NOT a keyframe", and the NOT was 
> accidentaly flipped.


> 3. The back_ptr calculation was using wrong timebase when searching for 
> back syncpoint


> 4. ff_nut_reset_ts() expected to get 'ts*time_base_count', but muxer only 
> gave it 'ts'. I fixed this by changing ff_nut_reset_ts() and demuxer 
> params...


> demuxer

> 1. "Bleh, libnut muxed this ;)\n" please, I fixed this bug over a year ago :)

rejected, we do not remove workarounds needed for demuxing/decoding

> 2. missing " && j<syncpoint_count" protection in the index parsing, as the 
> spec instructs...


> 3. small bug in info packet parsing..

after this, ... *type= type_str; above becomes unneeded i think

> Shall I commit?

The ones ok-ed, yes, and again seperate commits! And dont forget the
regression test checksums!

and thanks for debugging the lavf nut (de)muxer!

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080202/e8fef5b4/attachment.pgp>

More information about the ffmpeg-devel mailing list