[FFmpeg-devel] [PATCH] Fix ffmpeg crash on G3 based computers introduced with revision 10637

[Patrice Bensoussan]

On 9 Feb 2008, at 12:23, Diego Biurrun wrote:

> On Sat, Feb 09, 2008 at 12:11:01PM +0000, Patrice Bensoussan wrote:
>>
>> It seems that ffmpeg is trying to use altivec on PowerPC G3  
>> although it's
>> not available. This was introduced with revision 10637. Here is a  
>> patch to
>> fix the issue.
>>
>> --- libavcodec/mpegvideo.c	(revision 11880)
>> +++ libavcodec/mpegvideo.c	(working copy)
>> @@ -152,7 +156,8 @@
>> #elif defined(HAVE_ALTIVEC)
>> -    MPV_common_init_altivec(s);
>> +    if ( has_altivec() )
>> +        MPV_common_init_altivec(s);
>> #elif defined(ARCH_BFIN)
>
> This looks wrong, the code is already protected by HAVE_ALTIVEC and
> should not be compiled on your machine.

No it's not wrong. I want to compile with altivec support so that I  
can use that on a G4, but have ffmpeg still work on G3 hence the need  
to do check at run time to detect altivec. I am not compiling for my  
machine only.

Patrice