[FFmpeg-devel] [PATCH] Fix ffmpeg crash on G3 based computers introduced with revision 10637

[Patrice Bensoussan]

On 9 Feb 2008, at 18:04, Michael Niedermayer wrote:

> On Sat, Feb 09, 2008 at 06:56:46PM +0100, Diego Biurrun wrote:
>> On Sat, Feb 09, 2008 at 06:28:09PM +0100, Michael Niedermayer wrote:
>>> On Sat, Feb 09, 2008 at 05:20:47PM +0000, Patrice Bensoussan wrote:
>>>>
>>>> On 9 Feb 2008, at 17:18, Diego Biurrun wrote:
>>>>
>>>>> On Sat, Feb 09, 2008 at 06:13:53PM +0100, Diego Biurrun wrote:
>>>>>> On Sat, Feb 09, 2008 at 02:45:49PM +0100, Michael Niedermayer  
>>>>>> wrote:
>>>>>>> On Sat, Feb 09, 2008 at 12:41:47PM +0000, Patrice Bensoussan  
>>>>>>> wrote:
>>>>>>>>
>>>>>>>> On 9 Feb 2008, at 12:22, Reimar D?ffinger wrote:
>>>>>>>>
>>>>>>>>> On Sat, Feb 09, 2008 at 12:11:01PM +0000, Patrice Bensoussan
>>>>>>>>> wrote:
>>>>>>>>>> It seems that ffmpeg is trying to use altivec on PowerPC G3
>>>>>>>>>> although it's
>>>>>>>>>> not available. This was introduced with revision 10637.  
>>>>>>>>>> Here is a
>>>>>>>>>> patch to
>>>>>>>>>> fix the issue.
>>>>>>>>>>
>>>>>>>>>> --- libavcodec/mpegvideo.c	(revision 11880)
>>>>>>>>>> +++ libavcodec/mpegvideo.c	(working copy)
>>>>>>>>>> @@ -61,6 +61,10 @@
>>>>>>>>>> extern void XVMC_decode_mb(MpegEncContext *s);
>>>>>>>>>> #endif
>>>>>>>>>>
>>>>>>>>>> +#ifdef HAVE_ALTIVEC
>>>>>>>>>> +extern int has_altivec(void);
>>>>>>>>>> +#endif
>>>>>>>>>
>>>>>>>>> That #ifdef is pointless.
>>>>>>>
>>>>>>> seconded
>>>>>>
>>>>>> #ifdef HAVE_XVMC
>>>>>> extern int  XVMC_field_start(MpegEncContext*s, AVCodecContext
>>>>>> *avctx);
>>>>>> extern void XVMC_field_end(MpegEncContext *s);
>>>>>> extern void XVMC_decode_mb(MpegEncContext *s);
>>>>>> #endif
>>>>>
>>>>> I mean why do we have the above lines in the mentioned file then?
>>>>
>>>> I was just about to ask the same question... We have some in a  
>>>> lot of
>>>> files.
>>>
>>> which files?
>>
>> Only two, here is a patch to replace that stuff.  OK to apply?
>
> seems ive already fixed half of it ...
> other half is ok of course

what about my patch? :)