[FFmpeg-devel] [PATCH] [1/??] [2/3] Basic infrastructure

[Vitor Sessak]

Hi and thanks for the review

Diego Biurrun wrote:
> On Sat, Feb 09, 2008 at 07:32:16PM +0100, Vitor Sessak wrote:
>> /*
>>  * video filters
>>  * copyright (c) 2007 Bobby Bingham
>>  *
>>  * This file is part of FFmpeg.
>>  *
>>  * FFmpeg is free software; you can redistribute it and/or
>>  * modify it under the terms of the GNU Lesser General Public
>>  * License as published by the Free Software Foundation; either
>>  * version 2.1 of the License, or (at your option) any later version.
>>  *
>>  * FFmpeg is distributed in the hope that it will be useful,
>>  * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>  * Lesser General Public License for more details.
>>  *
>>  * You should have received a copy of the GNU Lesser General Public
>>  * License along with FFmpeg; if not, write to the Free Software
>>  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>>  */
>>
>> #include "avfilter.h"
>>
>> //extern AVFilter avfilter_vf_xxxxxxx;
> 
> This file is pointless (obfuscation).  Why add an empty header file?

Well, it is pointless now, because for now there is no filters. But it 
should have extern declaration for all of them (like in the soc tree).

>> /*
>> >  * Filter layer
> 
> nit: filter
> 

[... lots of nits ...]

Agreed with all the nits.

-Vitor