[FFmpeg-devel] [PATCH] use standard macro for ATTR_ALIGN

Michael Niedermayer michaelni
Tue Feb 12 16:22:03 CET 2008

On Tue, Feb 12, 2008 at 08:59:13AM +0100, Diego Biurrun wrote:
> On Tue, Feb 12, 2008 at 01:59:20AM +0100, Michael Niedermayer wrote:
> > On Tue, Feb 12, 2008 at 12:32:57AM +0100, Diego Biurrun wrote:
> > > libavcodec/i386/idct_mmx.c duplicates a somewhat simplified version of
> > > 
> > > Here is a patch to replace it with DECLARE_ALIGNED.  OK to apply?
> > 
> > idct_mmx.c is from libmpeg2 and i see no sense in making future merges
> > from or to code from libmpeg2 harder.
> > 
> > Thus iam against ALL cosmetic changes to it, that includes the ones done
> > already.
> Don't hold your breath, libmpeg2 has been orphaned for years...

Everyone forks it, the forks are not orphaned. Merges between them will
be very hard ...

Just try
diff -u  libmpeg2/idct_mmx.c libavcodec/i386/idct_mmx.c
in mplayer and be surprised by how many cosmetics and few functional
changes are there already. Actually i dont even know if there are
any functional changes, its kinda hard to notice in >800 lines of
changes. :)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080212/0e88743a/attachment.pgp>

More information about the ffmpeg-devel mailing list