[FFmpeg-devel] [PATCH] remove MSVC cruft
Tue Feb 12 18:55:16 CET 2008
On Tue, Feb 12, 2008 at 05:45:56PM +0100, Michael Niedermayer wrote:
> On Tue, Feb 12, 2008 at 05:19:28PM +0100, Reimar D?ffinger wrote:
> > On Tue, Feb 12, 2008 at 05:12:07PM +0100, Michael Niedermayer wrote:
> > > On Tue, Feb 12, 2008 at 04:39:24PM +0100, Reimar D?ffinger wrote:
> > > > working code > broken at compile-time >>> broken at runtime.
> > >
> > > you forget:
> > > working > broken
> > >
> > > and a #error in the default case _BREAKS_ ALL non GNU compilers, ffmpeg
> > > would no longer need just ISO C + POSIX but GNU
> > Yes, but your suggestion would/could land at "broken at runtime" with
> > some compilers.
> I prefer broken with some compiler over broken with all compilers
> I dont understand why you want a #error in the _default_ path?
To move the potential failure from runtime to compiletime.
It's two seconds for anyone to fix who knows what they are doing.
> If there was a HAVE_ASM or so that could be used to choose between #error
> and nothing ...
Such a HAVE_ASM would be the only real solution to this.
Though I'd then be for doing HAVE_ASM -> default to GNU case, default to
plain C otherwise.
More information about the ffmpeg-devel