[FFmpeg-devel] [PATCH] Read ogg stream language
Thu Feb 14 15:31:58 CET 2008
On Thu, Feb 14, 2008 at 02:06:37PM -0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger wrote:
> > On Thu, Jan 31, 2008 at 11:57:35PM +0100, Reimar D?ffinger wrote:
> >> attached patch makes vorbis_comment (which lacks a ff_ prefix btw) parse
> >> the language tag into AVStream.language (if a mapping is known).
> >> It also adds vorbis comment parsing to oggparseogm.c (I would apply as a
> >> second step).
> >> The code is probably improvable, the mapping list even more so.
> > So is this rejected, should it be done differently or just applied?
> I'd prefer if a mapping of common language names to codes were kept
> outside the ogg demuxer. It could be useful to someone else.
Sure, where? libavformat/utils.c? A new file (seems like overkill)?
ff_ or av_ (i.e. just internal or public)?
More information about the ffmpeg-devel