[FFmpeg-devel] [PATCH] Fix ffmpeg crash on G3 based computers introduced with revision 10637

Alexander Strange astrange
Sat Feb 16 00:47:35 CET 2008


On Feb 15, 2008, at 6:27 PM, Patrice Bensoussan wrote:

>
> On 15 Feb 2008, at 21:33, Guillaume Poirier wrote:
>
>> Hello folks,
>>
>> Le 14 f?vr. 08 ? 00:38, Patrice Bensoussan a ?crit :
>>
>>>
>>> On 9 Feb 2008, at 18:13, Michael Niedermayer wrote:
>>>
>>>> On Sat, Feb 09, 2008 at 06:08:34PM +0000, Patrice Bensoussan wrote:
>>>>> what about my patch? :)
>>>>
>>>> iam not altivec maintainer :)
>>>
>>> Just a quick reminder if there is any altivec maintainer
>>> around... ;-)  who would that be? Guillaume?
>>
>> I'd prefer the attached patch.
>>
>> Please have a look at it, and test it.
>
> I can't test it as I only have an intel based Mac now, but patch looks
> wrong... (missing not in front of has_altivec()). Otherwise, I am ok
> with it...

mm_flags & MM_ALTIVEC has already been set, you don't need another  
check.

Also, has_altivec() shouldn't be a global symbol without a prefix...



More information about the ffmpeg-devel mailing list