[FFmpeg-devel] [PATCH] [2/??] [2/3] Filter graphs - Basic infrastructure

[Diego Biurrun]

On Sat, Feb 16, 2008 at 12:44:04PM +0100, Vitor Sessak wrote:
> See $subj.
>
> /**
>  * Given the link between the dummy filter and an internal filter whose input
>  * is being exported outside the graph, this returns the externally visible
>  * link.
>  */
> static inline AVFilterLink *get_extern_input_link(AVFilterLink *link)
> {
>     GraphLinkContext *lctx = link->src->priv;
>     return lctx->graph->inputs[link->srcpad];
> }
> 
> /**
>  * Given the link between the dummy filter and an internal filter whose input
>  * is being exported outside the graph, this returns the externally visible
>  * link.
>  */
> static inline AVFilterLink *get_extern_output_link(AVFilterLink *link)
> {
>     GraphLinkContext *lctx = link->dst->priv;
>     return lctx->graph->outputs[link->dstpad];
> }

The Doxygen comments are identical, the functions are not.

>     /* Once everything is merged, it's possible that we'll still have
>      * multiple valid choices of colorspace. We pick the first one. */

multiple valid colorspace choices

> #ifndef FFMPEG_AVFILTER_GRAPH_H
> #define FFMPEG_AVFILTER_GRAPH_H

The convention is to use the filename as multiple inclusion guard,
without inserting underscores.

>  * Load a filter graph description from a file

missing period

>  * @param filename Name of the file from which to load the description
>  * @return         Pointer to the description on success.  NULL on failure

Missing period, a comma might be better.

> /**
>  * Free a filter graph description

missing period

>  * @param desc The graph description to free
>  */
> void avfilter_graph_free_desc(AVFilterGraphDesc *desc);
> 
> /**
>  * Add an existing filter instance to a filter graph.
>  * @param graph  The filter graph
>  * @param filter The filter to be added
>  */
> void avfilter_graph_add_filter(AVFilterContext *graphctx, AVFilterContext *filter);
> 
> /**
>  * Configure the formats of all the links in the graph

missing period

>  */
> int avfilter_graph_config_formats(AVFilterContext *graphctx);
> 
> /**
>  * Configure the resolution, etc of all links in the graph

missing period, etc.

> #endif  /* FFMPEG_AVFILTER_H */

This disagrees with the name used above.

Diego