[FFmpeg-devel] [PATCH] fix build with --disable-encoders
Sat Feb 23 19:32:28 CET 2008
Alexander Strange <astrange at ithinksw.com> writes:
> On Feb 23, 2008, at 7:22 AM, M?ns Rullg?rd wrote:
>> Alexander Strange <astrange at ithinksw.com> writes:
>>> On Feb 22, 2008, at 2:56 PM, Michael Niedermayer wrote:
>>>> Why is there an #ifdef CONFIG_ENCODERS there at all?
>>>> Its gccs job to omit unused static functions.
>>> Well, if you want...
>>> Attached patches:
>>> * remove those uses of CONFIG_ENCODERS from dsputil_mmx
>>> * add -Wno-unused-function to the build
>> I don't like this. The warning about unused stuff often helps spot
>> dead code that should be removed.
> Let's only add it for --disable-encoders, then. I'd rather not mark
> everything in dsputil_mmx as unused since there's a lot of functions
> and they usually are used, so that would have the same problem. Some
> other files (h263, msmpeg4) also put static functions under
> CONFIG_ENCODERS; they'll have the same problem if anyone changes that.
> It's too bad 'enabled encoders' is only set lower down, but I don't
> think it's too unclean. I could move this line down there, of course.
> Index: configure
> --- configure (revision 12181)
> +++ configure (working copy)
> @@ -1788,6 +1788,7 @@
> check_cflags -Wwrite-strings
> check_cflags -Wtype-limits
> enabled extra_warnings && check_cflags -Winline
> +enabled_any $ENCODER_LIST || check_cflags -Wno-unused-function
That way lies a big mess, not unlike the one we had before I cleaned
up the configure script.
I really don't understand why Michael doesn't like placing stuff
inside #ifdef CONFIG_ENCODERS.
mans at mansr.com
More information about the ffmpeg-devel