[FFmpeg-devel] [PATCH] fix build with --disable-encoders
Sun Feb 24 14:44:09 CET 2008
On Sat, Feb 23, 2008 at 09:44:05PM +0100, Michael Niedermayer wrote:
> On Sat, Feb 23, 2008 at 06:32:28PM +0000, M?ns Rullg?rd wrote:
> > I really don't understand why Michael doesn't like placing stuff
> > inside #ifdef CONFIG_ENCODERS.
> Because its extra maintaince work and leads to hard to find bugs.
> Just look in this thread,
> it was about some code which ended up under that #ifdef which then
> broke compilation with --disable-encoders. The first proposed fix (which
> needed reviewing time) would have fixed it by disabling some png
> decoding optimizations. If i would have missed that (possible, iam just
> a human ...) --disable-encoders would have caused the decoders to be
> mysteriously slower.
I'm with Mans on this one, one more #ifdef in dsputil_mmx.c will not
hurt, but the warning about unused code is useful.
It might be good to split off encoding-related stuff from that file but
this question is orthogonal to adding one more #ifdef.
> Without #ifdefs none of these problems would have occured. The warnings
> can as well be suppressed by attribute unused or -wno-whatever.
That would have to be a lot of attributes..
More information about the ffmpeg-devel