[FFmpeg-devel] [PATCH] fix build with --disable-encoders

Aurelien Jacobs aurel
Mon Feb 25 22:50:16 CET 2008

M?ns Rullg?rd wrote:

> Aurelien Jacobs <aurel at gnuage.org> writes:
> > Michael Niedermayer wrote:
> >
> >> On Sun, Feb 24, 2008 at 02:44:09PM +0100, Diego Biurrun wrote:
> >> > 
> >> > It might be good to split off encoding-related stuff from that
> >> > file but this question is orthogonal to adding one more #ifdef.
> >> 
> >> No, its not orthogonal, ifdef CONFIG_ENCODERS is specific to the
> >> case of mixed encoder and decoder code, if its split the encoder
> >> ifdefs become unneeded.
> >
> > OK. Attached patch splits encoding part of dsputil_mmx in its own
> > file. It removes all #ifdef CONFIG_ENCODERS without adding any
> > warning, without needing -wno-whatever.
> > It should please everyone.
> > (Note that the patch is compressed because it's big, but basically,
> > it only moves encoder functions to dsputilenc_mmx.c)
> >
> > I guess the patch is OK, so I will apply it very soon.
> What do you mean by "very soon"?

I thought something like a few hours... But I may very well forget
about it and apply it only in a few days...

>  If it's not your code, you should wait for the maintainer to
> comment.

Sure. But I interpreted Michael comment almost like a hidden
request to split this file ;-). And thus I assumed he is OK
with this...
Anyway, I will now wait for a formal approval.


More information about the ffmpeg-devel mailing list