[FFmpeg-devel] [PATCH] Microsoft Interix support

[pross at xvid.org]

On Thu, Feb 21, 2008 at 10:25:38PM +0000, M?ns Rullg?rd wrote:
> > - configure: vhooks requires -export-dynamic and this causes
> >   a false-positive when configure tests for closesocket().
> I don't understand this.  Could you please post the resulting
> config.err?

I won't waste everyone's time. The supplied interix binutils are buggy.
ld fails consitently when the -export-dynamic flag is given, and vhooks
requires -export-dynamic. Interix provides libdl:dlopen, so further tinkering
on my end is required.

% gcc -export-dynamic test.c
.rel.internal 250 240:
/bin/ld: BFD 2.13.90 20021111 assertion fail ../../src/bfd/cofflink.c:3174

> > - des.h uses uint64_t, but only includes inttypes.h.
> >   according to the iso, only stdint.h has to define uint64_t
> As other's have said, this is a bug in your system.

Agree, but (-pedantic) my statement still holds water. des.h doesn't
need intypes.h. Patch enclosed.

> > -Dstrtoll=strtol
> > -Datoll=atol
> That's dangerous.  You could be truncating values (strtol) or invoking
> undefined behaviour (atol).

Agree also. The debian-interix crew have suggested some better fixes
<http://debian-interix.net/>.

> While this is certainly clean, it cannot be accepted until an adequate
> explanation has been provided.

No rush; more work is needed. I shall submit a revised patch when the ld
issue is resolved.

Cheers,
-- pete
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-des-stdint.diff
Type: text/x-diff
Size: 337 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080226/765c5685/attachment.diff>