[FFmpeg-devel] [PATCH][0/4]: MMS base and MMSH implementation
Mon Jan 7 14:04:43 CET 2008
On Thu, 2007-12-13 at 23:03 +0100, Michael Niedermayer wrote:
> On Thu, Dec 13, 2007 at 04:29:26PM +0100, Bj?rn Axelsson wrote:
> > On Thu, 2007-11-29 at 11:00 +0100, Bj?rn Axelsson wrote:
> > > This is basically the same as my old MMS patch, only somewhat updated
> > > and split into smaller patches (one per file).
> > >
> > > Patch 1 and 2 are only new files and can be applied in any order.
> > > Patch 3 depends on 1 and 2, but still only touches the new files.
> > > The fourth patch in this series contains the makefile changes and
> > > protocol registration code, and should not be applied before the other
> > > three are applied. Only when this patch is applied can the new code be
> > > compiled and used.
> > >
> > > The complete series passes "make test".
> > Ping?
> > This has hasn't been reviewed in two weeks. Please let me know if I can
> > do anything more to help.
> spliting the patch per files, (it seems thats what you did) does not help
> me review it actually it makes it harder, what would help is split it
> in some self contained way
Splitting into seperate files seemed like a useful compromise to me,
since it would allow me to fix minor issues in a single file without you
having to review everything again.
I have more (though smaller) patches in the pipeline waiting for this to
pass. It is very frustrating for me not being able to get these patches
passed, but I understand that you have limited time and motivation.
> a totally hypothetical and probably not applicable variant would be
> 1. a patch for just establishing the connection
> 2. a patch for reading packets
> 3. a patch which adds seeking
> 4. a patch which adds pause support
> 5. a patch which adds support to send back connection statistics to the servr
The above would indeed be very hard to do without a lot of extra work on
my end and a big risk of introducing bugs and/or dead code in the
Anyhow. Attached is a combined version of the first three patches. They
are updated for current SVN including the recent changes in the "unused"
The fourth patch was the makefile stuff, which still applies and passed
review I believe.
I would also like to remind you about the av_url_read_fseek_api.diff
patch that was never applied:
Bj?rn Axelsson Phone: +46-(0)90-18 98 97
Intinor AB Fax: +46-(0)920-757 10
Interactive Television & Digital Media Distribution
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 51661 bytes
Desc: not available
More information about the ffmpeg-devel