[FFmpeg-devel] [RFC] Factorize some code from CAVS and H.264
Thu Jan 10 12:12:51 CET 2008
On Wed, Jan 09, 2008 at 11:48:20PM +0100, Christophe GISQUET wrote:
> I noticed that CAVS (cavsdsp_mmx.c) uses the following macros from H.264:
> - TRANSPOSE4 (dsputil_mmx.c, appeared in r1365; last changed in r8939)
> - SUMSUB_BA (idct_mmx.c r4329, then h264dsp_mmx.c r4338; never changed)
> In addition, such macros can be used in other dsp stuff (iDCT stuff
> mostly), so factorizing makes sense to me. TRANSPOSE8 is another candidate.
> Now, there is a plurality of file origins, the macros had little change
> throughout their history, so I'm inclined to thing it's not worth copying
> dsputil_mmx.c (both file and history) to a new file and work
>> from it.
> Then, name to pick. Considering all those macros come from H.264 code, and
> are only macros, I would name it h264dsp_mmx.h.
no, this code is not h264 specific
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel