[FFmpeg-devel] [Patch] Behaviour of liba52 decoder

Thorsten Jordan tjordan
Fri Jan 11 08:40:51 CET 2008

Michael Niedermayer schrieb:
> On Thu, Jan 10, 2008 at 02:00:24PM +0100, Thorsten Jordan wrote:
>> Ivo schrieb:
>>> On Thursday 10 January 2008 13:24, Thorsten Jordan wrote:
>>>> Michael Niedermayer schrieb:
>>>>> Hi
>> +    if (buf_size < len) {
>> +        av_log(avctx, AV_LOG_ERROR, "Error decoding frame, not enough bytes\n");
>> +        return -1;
>> +    }
> Please move this check before setting anything like the sample_rate.
> A packet of the wrong size is not convincing in terms of carring correct
> sample_rate, channels, ... information

Thank you for your feedback.

I can fix the patch, but would it be of interest, if the liba52-wrapper
would get removed soon?

After reading mails up to now, it seems that the native decoder is a
good replacement of liba52, same features, not slower...

Regards, Thorsten

More information about the ffmpeg-devel mailing list