[FFmpeg-devel] [PATCH] Faster ff_sqrt()

Michael Niedermayer michaelni
Sun Jan 13 19:49:04 CET 2008

On Sun, Jan 13, 2008 at 07:14:04PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Sun, Jan 13, 2008 at 10:52:13AM -0700, Loren Merritt wrote:
> > On Sun, 13 Jan 2008, Vitor Sessak wrote:
> > > I saw in the thread "Copy-on-write pages statistics" that roqaudioenc.c
> > > is a big copy-on-write memory usage offender. I think that
> > > increasing the memory usage of FFmpeg by 16kb just for a table used in a
> > > game format encoder is not a good idea. So I'm sending a new, faster
> > > ff_sqrt(), so I can remove the table completely without too much speed loss.
> I don't think it is faster for value < 128... And it is "insanely" more
> complex. At least I find it really, really ugly, but maybe that's just
> me...

That was exactly my thought as well when i saw the patch.
If anyone wants a faster sqrt() please find a simlper solution
That is unless ff_sqrt() would really affect an important codec speedwise.
But it doesnt AFAIK


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080113/9a3e11ed/attachment.pgp>

More information about the ffmpeg-devel mailing list