[FFmpeg-devel] [PATCH] attachments support in matroska demuxer

Evgeniy Stepanov eugeni.stepanov
Thu Jan 17 01:43:24 CET 2008

On Thursday 17 January 2008 03:00:26 Aurelien Jacobs wrote:
> OK. Here are things issues in this patch:
>  - CODEC_TYPE_NB must stay at the end of the enum.
>  - Adding attachments to AVFormatContext is probably a leftover from
>    your previous patch.
>  - I don't like the fake MATROSKA_TRACK_TYPE_ATTACHMENT and everything
>    depending on it.

I was not 100% sure that it is safe to create av_streams at that point. The 
code somehow suggested that av_streams and MatroskaTracks are always kept in 
sync. If they are not, your variant is obviously better.

>  - I don't think CODEC_ID_ATTACHMENT is of any use if it's used for
>    every kind of attachement. CODEC_TYPE_ATTACHMENT already gives the
>    same information.
> I fixed all those issues in the attached patch.
> Moreover, I tried to associate a specific CODEC_ID_* to different kind
> of attachements. To me, this seems like a good idea, but I would like
> to know what others think about it ?

I just want to point out that it is a partial solution: ff_mkv_mime_tags 
surely does not contain everything that can possibly come as an attachment. 
For instance, "application/x-font" should also be mapped to CODEC_ID_TTF.

More information about the ffmpeg-devel mailing list