[FFmpeg-devel] Memory leak in h264

Michael Niedermayer michaelni
Tue Jan 22 21:01:44 CET 2008

On Tue, Jan 22, 2008 at 02:46:46PM -0500, Jeff Downs wrote:
> On Tue, 22 Jan 2008, Michael Niedermayer wrote:
> > i suspect that will break multithreaded decoding by using the same buffer
> > for all threads
> > 
> > the fix might be to always let init_duplicate_context allocate all
> > the *edge_emu_buffer, instead of just for the first context and then
> > allocate the H264Contexts and copy the MpegEncContexts into them
> I'd already started on fixing it differently when I saw this, so here's 
> what I came up with. 

honestly, i dont think this is the cleanest way to solve it ...
I really think we should try to minimize the number of variables which get
initialized in mpegideo.c AND h264.c.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080122/85c989e8/attachment.pgp>

More information about the ffmpeg-devel mailing list