[FFmpeg-devel] regression - mpeg2 interlace/topfield flags not set anymore

[Diego Biurrun]

On Sat, Jan 26, 2008 at 12:57:15AM +0100, christophelorenz wrote:
> 
> I took rev 11608 and reverted some code to locate the problem and found 
> out that reverting the last change of ffmpeg.c fixes the problem.
> 
> on svn, last ffmpeg.c line 3278 :
>     for(i=0; i<opt_name_count; i++){
>         char buf[256];
>         const AVOption *opt;
>         const char *str= av_get_string(avformat_opts, opt_names[i], 
> &opt, buf, sizeof(buf));
>         if(str && (opt->flags & AV_OPT_FLAG_ENCODING_PARAM))
>             av_set_string(oc, opt_names[i], str);
>     }
> 
> replaced by previous code : (from rev 11117)
>     for(i=0; i<opt_name_count; i++){
>         const AVOption *opt;
>         double d = av_get_double(avformat_opts, opt_names[i], &opt);
>         if(!isnan(d) && (opt->flags&AV_OPT_FLAG_ENCODING_PARAM))
>             av_set_double(oc, opt_names[i], d);
>     }

This would be much more readable if you provided a (unified) diff.

Diego