[FFmpeg-devel] [RFC] write standard stsd tags and objecttype for mp4/3gp

[Baptiste Coudurier]

Michael Niedermayer wrote:
> Hi
> 
> On Mon, Jan 28, 2008 at 02:46:15PM +0100, Baptiste Coudurier wrote:
> [...]
>>> [...]
>>>> +    track->tag = tag;
>>>>      return tag;
>>> i think retunng the tag and vissibly setting it is more readable
>>> that is IMHO
>>>  track->tag = mov_find_video_codec_tag(s, track);
>>> is better than
>>> if (!mov_find_codec_tag(s, track)) {
>>>     av_log(s, AV_LOG_ERROR, "track %d: could not find tag for codec\n", i);
>>>     return -1;
>>> }
>>>
>>> where mov_find_codec_tag() has a "hidden" sideeffect of setting track->tag
>>>
>> Im fine with it.
>>
>> Updated patch attached.
> 
> ok
> 

Applied.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312