[FFmpeg-devel] [PATCH] make multiply-used swscale constants global

Michael Niedermayer michaelni
Tue Jan 29 15:29:09 CET 2008


On Tue, Jan 29, 2008 at 03:15:27PM +0100, Reimar D?ffinger wrote:
> Hello,
> there are some constants that are used in swscale, rgb2rgb and yuv2rgb.
> Instead of having a copy for each, attached patch makes these global.
> Is this ok?

ok


[...]
> P.S. it seems there is also quite a bit of code duplicated, but I'm not
> going to fix this at least for now

not ok, fix it now ;)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080129/5846b3cc/attachment.pgp>



More information about the ffmpeg-devel mailing list