[FFmpeg-devel] [RFC] replace some static with asm_visibility or?so

Balatoni Denes dbalatoni
Wed Jan 30 22:53:47 CET 2008


Wednesday 30 January 2008 21:10-kor M?ns Rullg?rd ezt ?rta:
> Then we end up with rubbish like the Vorbis encoder.

Why is it rubbish? The project wanted a vorbis encoder, the project got a 
vorbis encoder. IMHO it is as good as a lossy encoder without a psychoacustic 
model can be (mind you, I didn't write the vorbis encoder, Oded did).

> > Patches that would fit my description would be for example Ian
> > Caulfield's MLP decoder, some of Christophe Gisquet's optimizations,
> > Siarhei Siamashka's arm idct optimizations (this also shows a double
> > standard, because Mans - who has SVN commit rights - was free to
> > commit suboptimal code, that has never been accepted from anybody
> > without SVN commit rights - I must note however, that IMO it's good
> > that Mans' code was made available early in SVN) or even my sparc
> > idct optimizations - which eventually were comitted, but none of the
> > others I have mentioned have been up to now (for quite some time).
> The possible optimisations to the ARM IDCT are minor compared to the
> improvement over the plain C version, and the code in SVN is clean.

Yes, those words were also mostly true about my sparc idct, but it was not 
acceptable. Btw I agree with you, and it is good you comitted your idct.

> I'm not saying it shouldn't be improved, of course.  In fact, I might
> just revisit those patches, which I'd all but forgotten about.  If
> submissions go ignored for a long time, a friendly reminder is often
> useful to get things moving again.  It's easy to forget about things
> you were too busy to look at in detail at the time they were posted.

Well I am sure arm users (and there are some) will be glad if you revisit 
Siarhei's patches.


More information about the ffmpeg-devel mailing list