[FFmpeg-devel] [PATCH] support text subtitles in ogm

Reimar Döffinger Reimar.Doeffinger
Thu Jan 31 23:32:04 CET 2008


Hello,
On Thu, Jan 31, 2008 at 10:25:38PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> > almost a trivial patch.
> > Sample:
> > http://samples.mplayerhq.hu/ogg/bgc.sub.dub.ogm
> > Ok to apply?
> >
> > [...]
> > +ogg_codec_t ogm_text_codec = {
> > +    .magic = "\001text",
> > +    .magicsize = 6,
> 
> I suspect magicsize should be 5.

Good old copy-and-paste gets me each time ;-)

> > +    .header = ogm_header,
> > +    .packet = ogm_packet
> > +};
> 
> Otherwise OK.

Applied.




More information about the ffmpeg-devel mailing list