[FFmpeg-devel] [PATCH] simplify mpeg12/8bps pix_fmt set

[Ivan Kalvachev]

On Sat, Jul 19, 2008 at 6:09 AM, Baptiste Coudurier
<baptiste.coudurier at smartjog.com> wrote:
> Hi
>
> $subject, did it ever work ?
>
> get_format seems to be used/introduced for XVMC, is it still in use ?

I don't like it.

First get_format() was not introduced for XvMC, I just took advantage of it.

Second in 8bps is using it for real, so you remove functionality.

Third. While working on xvmc, I found out that there is no function
that would tell the image properties (pix_fmt, width, height) to the
video system. As effect it is initialized on get_buffer() or after
first frame is decoded, sometimes this may cause interesting race
conditions. e.g. when stream changes resolution.
It simplifies player a lot if each codec calls get_format() just for
that purpose. Unfortunately nobody else seems to be interested in
that.