[FFmpeg-devel] [PATCH] Cosmetics: improve long names for ffm muxer and demuxer

[Baptiste Coudurier]

Diego Biurrun wrote:
> On Sun, Jul 20, 2008 at 11:53:09AM -0700, Baptiste Coudurier wrote:
>> Diego Biurrun wrote:
>>> On Sat, Jul 19, 2008 at 06:03:30PM -0700, Baptiste Coudurier wrote:
>>>> Stefano Sabatini wrote:
>>>>> --- libavformat/ffmdec.c	(revision 14284)
>>>>> +++ libavformat/ffmdec.c	(working copy)
>>>>> @@ -477,7 +477,7 @@
>>>>>  
>>>>>  AVInputFormat ffm_demuxer = {
>>>>>      "ffm",
>>>>> -    NULL_IF_CONFIG_SMALL("ffm format"),
>>>>> +    NULL_IF_CONFIG_SMALL("FFserver live feed Muxer"),
>>>>>      sizeof(FFMContext),
>>>> I don't think this is the right name.
>>> Well, it is called by that name in the code:
>>>
>>>  * FFM (ffserver live feed) demuxer
>> Do we add "Muxer" to names ? No, at least not in mxf.c and mov.c
> 
> No, we do not.

So why would you accept this name ?

>> And this line was changed recently, check svn blame/log.
> 
> You changed it from
> 
>   * FFM (ffserver live feed) muxer and demuxer
> 
> to 
> 
>   * FFM (ffserver live feed) demuxer
> 
> while splitting the files.  How is this relevant to the discussion at
> hand?
> 

Because before that, it was "encoder and decoder".

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA