[FFmpeg-devel] [PATCH] Get rid of p

[Michael Niedermayer]

On Fri, Jun 06, 2008 at 05:09:27PM +0100, Ramiro Polla wrote:
> Hello,
>
> By the message subject you probably asked yourself "what 'p'?".
>
> Exactly, I ask myself the same question when reading the source.
>
> I find one-letter variable names hard to grep for and hard to understand. 
> Are patches to get rid of them or use more descriptive names welcome?
>
> Particular cases that come to my mind are:
>  - 's', used throughout FFmpeg to mean context. I suggest to change them to 
> ctx;
>  - 'p', used in video encoders for something that I still have no idea what 
> is doing there.
>
> Ramiro Polla

> Index: utils.c
> ===================================================================
> --- utils.c	(revision 13671)
> +++ utils.c	(working copy)
> @@ -2779,7 +2779,6 @@
>  
>  int64_t parse_date(const char *datestr, int duration)
>  {
> -    const char *p;
>      int64_t t;
>      struct tm dt;
>      int i;
> @@ -2808,12 +2807,11 @@
>  
>      memset(&dt, 0, sizeof(dt));
>  
> -    p = datestr;

int64_t parse_date(const char *p, int duration)

and your patch is much smaller
we can discuss the renaming then seperately ...
iam not sure if its good or not for the functions in your patch ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080607/d07b9a2a/attachment.pgp>