[FFmpeg-devel] [PATCH] Factorize in ffmpeg.c the options context setting

Michael Niedermayer michaelni
Sun Jun 8 15:41:22 CEST 2008


On Sun, Jun 08, 2008 at 03:35:29PM +0200, Stefano Sabatini wrote:
> On date Sunday 2008-06-08 14:38:11 +0200, Michael Niedermayer encoded:
> > On Sun, Jun 08, 2008 at 12:37:24PM +0200, Stefano Sabatini wrote:
> > > Hi, as in subject, regression test passed.
> > > 
> > > Regards.
> > > -- 
> > > FFmpeg = Furious and Fucking MultiPurpose EntanGlement
> > 
> > > Index: ffmpeg.c
> > > ===================================================================
> > > --- ffmpeg.c	(revision 13707)
> > > +++ ffmpeg.c	(working copy)
> > > @@ -2684,6 +2684,22 @@
> > >      return codec->id;
> > >  }
> > >  
> > 
> > > +/**
> > > + * Sets in \p ctx all the options set in \p opts_ctx for all the \p
> > > + * ctx options for which opt->flags & \p flags == flags is true.
> > > + */
> > > +static void set_context_opts(void *ctx, void *opts_ctx, int flags)
> > 
> > I know what the function does, but i do not understand the doxy above,
> > i think thats not good.
> 
> I agree, I'm trying harder with the attached patch.

Could you send a patch without the doxy? :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080608/0c7d8267/attachment.pgp>



More information about the ffmpeg-devel mailing list