[FFmpeg-devel] [RFC] additinal desc_type for dtshd mpeg-ts demuxer

[Baptiste Coudurier]

Hi M?ns,

M?ns Rullg?rd wrote:
> elupus <elupus at ecce.se> writes:
> 
>>> I highlighted the interesting ones. Oddly is not listing 0x8a as a dts
>>> track which lavf's demuxer does. Would a patch be accepted adding the
>>> desc_types not in lavf currently, under the same hdmv check?
>>>
>> Something like the following. It's only tested for type 0x86 at the moment.
>>
>> ps. Patch might not apply to svn, as I manually removed quite a few hunks.
>> It's mainly for comments.
>>
>> Joakim
>>
>> Index: libavformat/mpegts.c
>> ===================================================================
>> --- libavformat/mpegts.c	(revision 13531)
>> +++ libavformat/mpegts.c	(working copy)
>> @@ -605,6 +617,12 @@
>>  
>>          /* now create ffmpeg stream */
>>          switch(stream_type) {
>> +        case STREAM_TYPE_AUDIO_HDMV_DTS_HD:
>> +        case STREAM_TYPE_AUDIO_HDMV_DTS_HD_MASTER:
>> +        case STREAM_TYPE_AUDIO_HDMV_AC3_TRUE_HD:
>> +        case STREAM_TYPE_AUDIO_HDMV_AC3_PLUS:
>> +            if(!has_hdmv_descr)
>> +                break;
>>          case STREAM_TYPE_AUDIO_MPEG1:
>>          case STREAM_TYPE_AUDIO_MPEG2:
>>          case STREAM_TYPE_VIDEO_MPEG1:
> 
> Move the case STREAM_TYPE_HDMV_DTS to that new group too, and remove
> the other hdmv-related if statement.

Btw shouldn't the TS demuxer demux all streams if possible, as track
type data if unknown ?

This would simplify things.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA