[FFmpeg-devel] [PATCH] AAC decoder

[Robert Swain]

2008/6/13 Michael Niedermayer <michaelni at gmx.at>:
> On Fri, Jun 13, 2008 at 11:17:51AM +0100, Robert Swain wrote:
>> 2008/6/12 Michael Niedermayer <michaelni at gmx.at>:
> [...]
>> > [...]
>> >> +        for(j=0; j<4; j++) {
>> >> +        if (ac->che[j][i]) {
>> >> +            sce_trans(ac, &ac->che[j][i]->ch[0]);
>> >> +        if (j == ID_CPE)
>> >> +            sce_trans(ac, &ac->che[j][i]->ch[1]);
>> >
>> > more odd indention
>>
>> The strange looking indentation is for lines of code that I altered I
>> left them at the same level of indentation to avoid mixing cosmetic
>> and functional changes. Is this what is wanted or if I edit lines, do
>> you want me to alter their indentation to be correct in the same
>> commit?
>
> If you edit a line due to a functional change, please also fix its indention.
> Only otherwise unchanged lines should be reindented in a seperate commit.
>
> That not only makes the reindent patch smaller, it also makes the functional
> changes patch easier to read as it is mostly correctly indented.

I guess I was being too strict about cosmetic changes. :) I'll
remember this for future reference.

Rob