[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [2/7] - pitch lag decoding

[Vladimir Voroshilov]

2008/6/25 Diego Biurrun <diego at biurrun.de>:
> On Tue, Jun 24, 2008 at 11:24:17PM +0700, Vladimir Voroshilov wrote:
>> 2008/6/18 Diego Biurrun <diego at biurrun.de>:
>> >
>> > TTBOMK both are synonyms.  I would prefer delay, which is the more
>> > common and more technical term and AFAICT it is used everywhere else.
>> > Go for delay.
>>
>> Done.
>> I didn't touch filename, though.
>> "acelp_pitch_delay" sounds too long for me
>> If you wish and there are no more fixes in the file i can rename it too.
>
> Yes, please rename it, it's just two characters more and using "delay"
> everywhere and calling the file "lag" is confusing and silly.

Done

[...]

>> + *    M    - ma prediction order
>
> ma?

Now it is "MA (Moving Average) prediction order"

>> + *    Predicted fixed codebook gain gc_p is computed using from
>> + *    known as predicted energies:
>
>
> "The predicted..."
>
> But this is very confusing.  What are you trying to say by "using from
> known as"?

Comment rewrited.

'make checkheaders' also fixed in this file.
Fix for other files will be sent in separate thread.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_acelp_lag64.diff
Type: text/x-diff
Size: 12440 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080625/747a8aea/attachment.diff>