[FFmpeg-devel] [PATCH] reduce global data in lavc

Stefan Gehrer stefan.gehrer
Wed Jun 25 16:17:37 CEST 2008


Michael Niedermayer wrote:
> On Wed, Jun 25, 2008 at 01:53:50PM +0200, Stefan Gehrer wrote:
>> I know that, but
>>
>> for (i = 0; i < 8; i++)
>>     s->custom_mode_alphabet[get_bits(gb, 3)] = i;
>>
>> could for example write only to s->custom_mode_alphabet[0] eight times
>> if there are 24 zero-bits in a row and then
>>
>> coding_mode = s->custom_mode_alphabet[get_vlc2(gb, s->mode_code_vlc.table, 
>> 3, 3)];
>>
>> could read from an index different to zero.
> 
> indeed, ive missed that possibility, so iam fine with either patch, apply
> what you prefer

Applied last version (on stack).

Stefan




More information about the ffmpeg-devel mailing list