[FFmpeg-devel] [PATCH] remove MSVC-specific
Sat Mar 8 22:00:36 CET 2008
On Sat, Mar 08, 2008 at 09:31:03PM +0100, Diego Biurrun wrote:
> On Sat, Mar 08, 2008 at 09:09:47PM +0100, Michael Niedermayer wrote:
> > On Sat, Mar 08, 2008 at 09:03:00PM +0100, Diego Biurrun wrote:
> > > On Mon, Feb 25, 2008 at 03:57:03PM +0100, Diego Biurrun wrote:
> > > > Here is a patch to remove an MSVC-specific definition from
> > > > libavutil/mem.h. MSVC is not supported and now we have a proper
> > > > fallback. Besides, it seems that the identifier is wrong anyway
> > > > and the condition is never true. This proves that if there should be
> > > > any sort of MSVC support, it should be maintained outside of FFmpeg
> > > > where it might actually get some testing.
> > >
> > > No one seemed to be against this patch, so here is an updated version.
> > patch rejected :)
> Seriously, we do not provide MSVC infrastructure in other places, why in
> this one?
Why not? :))
Seriously, its one hunk less to maintain for people who have hacked their
ffmpeg to be msvc compileable. And it does no harm to us.
Maybe we can one day even support MSVC fully, it just needs MSVC to
support standard C or someone to come up with a clean workaround. Like
a little perl script to convert the problematic syntax before feeding it
to the compiler.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel