[FFmpeg-devel] [PATCH] QT RLE header parser refactoring
Mon Mar 10 16:50:20 CET 2008
Michael Niedermayer wrote:
> Iam strongly against such macros, i dont belive that there is no clean way to
> factorize the code. Macros are forced code duplication, that is the code
> cannot be compiled to an object file without the duplication. Also having
> variable declaration and use split between macros reduces readability very
> significantly, and the only change this does is to the source, the object
> files as already said still always contain the duplication.
> Also the lines before as well as after the macro are also 1:1
> identical and thus should be in that macro.
Yeah. I didn't like the idea either, to be honest. :) I have better
ideas for refactoring I'll try next.
More information about the ffmpeg-devel