[FFmpeg-devel] [PATCH] replace hardcoded offset of CABACContext.bytestream with "m" operand

Michael Niedermayer michaelni
Mon Mar 17 22:59:51 CET 2008

On Mon, Mar 17, 2008 at 09:01:20PM +0000, Mans Rullgard wrote:
> ---
>  libavcodec/cabac.h |   54 ++++++++++++++++++++++-----------------------------
>  1 files changed, 23 insertions(+), 31 deletions(-)

Have you checked that gcc doesnt pessimize the code? Iam certain this
was written the way because it didnt work the other (cleaner) way around

I also like to see START/STOP_TIMER benchmarks. In adition to some 
confirmation that gcc still uses the same register for (c) and (c->bytestream)
And some confirmation that it doesnt cause failures or miscompilations on
gcc 2.95 and 3.* (3.3/3.4 being most relevant)
old gcc is very sensitive to the number of operands

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080317/b9609056/attachment.pgp>

More information about the ffmpeg-devel mailing list