[FFmpeg-devel] [PATCH] eliminate long from ByteIOContext structure

Diego Biurrun diego
Mon Mar 31 20:40:41 CEST 2008

On Mon, Mar 31, 2008 at 08:25:08PM +0200, Reimar D?ffinger wrote:
> On Mon, Mar 31, 2008 at 08:13:34PM +0200, Diego Biurrun wrote:
> > Here is a patch to remove long from the ByteIOContext structure with the
> > next major version bump.  This was recently requested, so let's give it
> > to people.  Possibly the use of uint32_t is better, I'm sure somebody
> > will point this out to me shortly if necessary.
> Since this is just a "wrapper" around the crc code in libavutil and that
> one uses uint32_t, yes uint32_t is better.
> But there is also the problem that the function assigned to
> update_checksum still is "unsigned long" always after your patch, which
> might break rather badly in some theoretical ABI.

I'm not following you here, where is update_checksum still unsigned
long?  Updated patch attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: avoid_long2.diff
Type: text/x-diff
Size: 897 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080331/40bc4f54/attachment.diff>

More information about the ffmpeg-devel mailing list