[FFmpeg-devel] [PATCH]Add Dirac support to ffmpeg via libdirac_* and Schroedinger libraries]

[Michael Niedermayer]

On Fri, May 02, 2008 at 09:58:38PM +1000, Anuradha Suraparaju wrote:
> 
> On Thu, 2008-05-01 at 13:55 +0200, Aurelien Jacobs wrote:
> > Anuradha Suraparaju wrote:
> > 
> > > On Wed, 2008-04-30 at 14:13 +0200, Diego Biurrun wrote:
> > > > 
> > > > Right.  Well, we are at an impasse then.  The Dirac demuxer and
> > > > parser need to be committed first.
> > > > 
> > > > So either Marco gets a move on or Anuradha has to try to get her
> > > > stuff or the SoC stuff merged.
> > > > 
> > > 
> > > I already have Marco's dirac parser and dirac mux/demux code in my
> > > local tree. Separating the parser, mux/demux code from the rest of
> > > his Dirac GSoC project is very simple. I could create a patch against
> > > the latest FFmpeg svn revision and email that to you for review if
> > > Marco is busy at the moment.
> > 
> > I think that would be much appreciated. (and 2 separate patches, one
> > for demux and one for parser, would be preferable)
> 
> I've attached the Dirac parser patch from Marco's GSoC project. This
> patch is against FFmpeg svn revision 13030.
[...]

> +#define DEBUG 1

why ?


[...]
> +    int parse_info_found;
[...]
> +    parse_info_found = pc->frame_start_found;

that local variable seems redundant

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080502/c46d5573/attachment.pgp>