[FFmpeg-devel] [PATCH] MMX for Win64

Reimar Döffinger Reimar.Doeffinger
Sun May 4 19:32:00 CEST 2008


On Sun, May 04, 2008 at 05:05:47PM +0100, M?ns Rullg?rd wrote:
> "Zuxy Meng" <zuxy.meng at gmail.com> writes:
> > 2008/5/4 M?ns Rullg?rd <mans at mansr.com>:
> >> It's wrong to use size_t here.  There is no guarantee that size_t
> >> is at all suitable.  For instance, it could legally be 64 bits on a
> >> 32-bit system, or 32 bits on a 64-bit system.
> >
> > What about intptr_t?
> 
> That's guaranteed to be at least as wide as a pointer.  Since we're
> not dealing with pointers here, it is incorrect to use it.  It is
> possible to have 32-bit pointers and 64-bit long.

What is required here (and what long is "misused" for) is native
register size. And since all of the modified code is x86 specific,
pointers and native register contents are not really distinguishable.
Still, the proposed patch just hacks a few places and is not a proper
solution.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list