[FFmpeg-devel] [PATCH] avoid sourcefile inclusion (vis and mlib in swscale)

Diego Biurrun diego
Mon May 5 12:08:12 CEST 2008

On Sun, May 04, 2008 at 10:48:20PM +0200, Luca Barbato wrote:
> Diego Biurrun wrote:
> > 
> > Mind alphabetical order and alignment please.
> Reordered in a second patch

Sorry, but this is complete nonsense.  There is no value in you
documenting your ABC troubles in the Subversion history.  On the
contrary, now we have an extra revision cluttering the log without any
value whatsoever and we will get another when I restore the looks of the
Makefile back to my liking.

If you cannot frigging memorize the ABC, then get a proper editor that
can do voodoo like M-x sort-lines for you.

I suspect this is a consequence of git rotting your brain (famous Linus
quote, woohoo).  Given that you already had committed a buggy version,
you chose to commit another one to fix up your mistakes (a complete
failure, BTW) and then push both upstream instead of pushing one
proper revision.

So if your your intent was to record your clumsiness for posterity, this
was a sweeping success.  If it was not, then well, hmm, you have already
gotten the idea...

Pardon the sarcasm, but how hard can this be?  We've discussed this so
many times, I'm not even sure if you got it right even once.  I must say
I have woken up ill-tempered today, but having to repeat myself for the
nth time is not helping my attitude.

Also, I fear that if everybody starts using git (in this way), our
history will soon look like

r1: hello world
r2: 10l
r3: 100l
r4: 1000l
r5: aaargh, really make it compile this time
r6: make it compile in the next spot
r7: omg, im sooo stupid
r8: woohooo, it compiles!!!
r9: k, umm, really make it print hello world now
r10: oops, forgot \n

I'm getting carried away here, but you get the idea.

Anyway, don't touch the Makefile again, I'll fix it myself.


More information about the ffmpeg-devel mailing list