[FFmpeg-devel] [PATCH] Print AV_NOPTS_VALUE in seek test
Mon May 5 18:49:42 CEST 2008
On Mon, May 05, 2008 at 05:35:37PM +0100, Ramiro Polla wrote:
> Ramiro Polla wrote:
>> Michael Niedermayer wrote:
>>> On Thu, May 01, 2008 at 09:28:37PM +0100, Ramiro Polla wrote:
>>>> Attached patch makes seek_test print AV_NOPTS_VALUE instead of some big
>>>> negative and apparently meaningless number.
>>> Complicating the code for no apparent reason, the regression tests are
>>> just for developers knowing what they do. And someone not knowing what
>>> the big meaningless number is wont be able to make any sense of
>>> "AV_NOPTS_VALUE" either.
> Could you please reconsider this?
> Seek tests with latest MinGW CVS only fail because of this printf. The
> tests don't really fail, but the way the results are printed do. This can
> easily be avoided in FFmpeg's side by writing cleaner output.
> Attached patch prints out -1 instead of AV_NOPTS_VALUE.
Uh.. could you please explain the sense behind that? Because like this,
you complicate the code _and_ it is just wrong...
More information about the ffmpeg-devel