[FFmpeg-devel] [PATCH] Print AV_NOPTS_VALUE in seek test

Michael Niedermayer michaelni
Mon May 5 20:46:37 CEST 2008

On Mon, May 05, 2008 at 05:35:37PM +0100, Ramiro Polla wrote:
> Hello,
> Ramiro Polla wrote:
>> Michael Niedermayer wrote:
>>> On Thu, May 01, 2008 at 09:28:37PM +0100, Ramiro Polla wrote:
>>>> Hello,
>>>> Attached patch makes seek_test print AV_NOPTS_VALUE instead of some big 
>>>> negative and apparently meaningless number.
>>> Complicating the code for no apparent reason, the regression tests are
>>> just for developers knowing what they do. And someone not knowing what
>>> the big meaningless number is wont be able to make any sense of
>>> "AV_NOPTS_VALUE" either.
>> Seek test fail on MinGW because MSVCRT doesn't properly printf() big 
>> numbers. Instead of printing
>> pts:-102481911520608.625000
>> it prints
>> pts:-102481911520608.600000
> Could you please reconsider this?
> Seek tests with latest MinGW CVS only fail because of this printf. The 
> tests don't really fail, but the way the results are printed do. This can 
> easily be avoided in FFmpeg's side by writing cleaner output.

Well if you really insist then try
#define ts2float(ts) ((ts) == AV_NOPTS_VALUE ? 0.0/0.0 : ts)

> Attached patch prints out -1 instead of AV_NOPTS_VALUE.

as reimar said, this is just wrong ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080505/8615a24d/attachment.pgp>

More information about the ffmpeg-devel mailing list