[FFmpeg-devel] [PATCH] h264/aac in flv

[Michael Niedermayer]

On Tue, May 06, 2008 at 10:20:32AM +0200, Baptiste Coudurier wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> > [...]
> >> @@ -369,6 +385,19 @@
> >>          size -= flv_set_video_codec(s, st, flags & FLV_VIDEO_CODECID_MASK);
> >>      }
> >>  
> >> +    if (st->codec->codec_id == CODEC_ID_AAC ||
> >> +        st->codec->codec_id == CODEC_ID_H264) {
> >> +        int type = get_byte(s->pb);
> >> +        size--;
> >> +        if (st->codec->codec_id == CODEC_ID_H264)
> >> +            pkt->pts = dts + get_be24(s->pb);
> >> +        if (type == 0) {
> >> +            if ((ret = flv_get_extradata(s, st, size - 1)) < 0)
> >> +                return ret;
> >> +            goto retry;
> >> +        }
> >> +    }
> > 
> > Are multiple type 0 packets allowed? extradata must be strictly global and
> > must never change. Maybe these could be passed like normal packets? In which
> > case that problem would disapear.
> 
> Quoting specs:
> "See ISO 14496-15, 5.2.4.1 for the description of
> AVCDecoderConfigurationRecord. This contains the same information that
> would be stored in an avcC box in an MP4/FLV file."
> "The AudioSpecificConfig is explained in ISO 14496-3."

well, then the patch is ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080506/e4c32fd2/attachment.pgp>