[FFmpeg-devel] [PATCH] MMX for Win64

Reimar Döffinger Reimar.Doeffinger
Wed May 7 11:49:46 CEST 2008


On Wed, May 07, 2008 at 10:27:57AM +0100, M?ns Rullg?rd wrote:
> Baptiste Coudurier wrote:
> > M?ns Rullg?rd wrote:
> >> There are good reasons not to use typedefs for structs (or pointers).
> >> I avoid doing it in new code.
> >
> > Oh, can you please elaborate a little ? Im really interested in knowing why.
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/CodingStyle;hb=HEAD#l270
> 
> Extrapolate from there.

Well, the thing that is the major claim, namely 'Lots of people think
that typedefs "help readability". Not so.' is not exactly convincing.
Luckily it's usually only one function argument that is a struct, but
if only considering readability I find
> int function(actx_t *a, bctx_t *b, cctx_t *c);
much better than
> int function(struct actx *a, struct bctx *b, struct cctx *c);
because the "struct"s use up a lot of space without adding any useful
information.

Greetings,
Reimar Doeffinger




More information about the ffmpeg-devel mailing list