[FFmpeg-devel] [PATCH] Properly check for sys/resource.h
Thu May 8 00:08:31 CEST 2008
On Wed, May 07, 2008 at 09:55:47AM +0100, Ramiro Polla wrote:
> Diego Biurrun wrote:
> > On Wed, May 07, 2008 at 09:32:19AM +0100, Ramiro Polla wrote:
> >> $subj
> >> --- ffmpeg.c (revision 13058)
> >> +++ ffmpeg.c (working copy)
> >> @@ -36,7 +36,9 @@
> >> -#if !defined(HAVE_GETRUSAGE) && defined(HAVE_GETPROCESSTIMES)
> >> +#ifdef HAVE_SYS_RESOURCE_H
> > Has the check for getrusage become redundant now?
> Kind of... Having sys/resource.h doesn't imply having getrusage(). I
> suppose the getrusage check could be removed afterwards. But then we
> call getrusage() under ifdef HAVE_SYS_RESOURCE_H?
Apparently it is not redundant. So I guess the patch is OK.
More information about the ffmpeg-devel