[FFmpeg-devel] [PATCH] Remove comparison of unsigned variable with zero

[Luca Abeni]

Hi,

Carl Eugen Hoyos wrote:
[...]
> dest_addr_len in udp.c is defined as size_t which is unsigned (if I 
> googled that correctly). Attached patch removes a comparison of 
> dest_addr_len with zero (fixes a warning when compiling with icc).
[...]
As I wrote in the previous email, I do not think that removing the error 
check is a good idea.
I have never seen this warning (even gcc 4.1 does not complain), but I 
think the attached patches are a better solution (I have no opinions 
about which one is better, so I attach all the three patches).


				Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warn_fix_1.diff
Type: text/x-diff
Size: 1410 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/e5ef17de/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warn_fix_2.diff
Type: text/x-diff
Size: 341 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/e5ef17de/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warn_fix_3.diff
Type: text/x-diff
Size: 745 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/e5ef17de/attachment-0002.diff>