[FFmpeg-devel] [PATCH] ff_shift (left shift with allowed negative offset) implementation

[Vladimir Voroshilov]

2008/5/11 Michael Niedermayer <michaelni at gmx.at>:
> On Sun, May 11, 2008 at 09:45:56AM +0700, Vladimir Voroshilov wrote:
>> 2008/5/11 Michael Niedermayer <michaelni at gmx.at>:
>> > On Sat, May 10, 2008 at 11:49:25PM +0700, Vladimir Voroshilov wrote:
>> >> 2008/5/10 Michael Niedermayer <michaelni at gmx.at>:
>> >> > On Sat, May 10, 2008 at 08:42:09PM +0700, Vladimir Voroshilov wrote:
>> >> >> 2008/5/10, Michael Niedermayer <michaelni at gmx.at>:
>> >>
>> >> [...]
>> >>
>> >> >> > and the name is not good, it should give some hint that offset is meant
>> >> >> > leftward and that value is signed.
>> >> >>
>> >> >> the given name is the best a can invent for it.
>> >> >> Please anybody suggest better.
>> >> >
>> >> > ff_bidir_sal makes sense to me but iam not sure if it makes sense to anyone
>> >> > else (ones not knowing x86 asm), sal being shift arithmetic (signed) left.
>> >> >
>> >> > maybe someone else has a better suggestion
>> >>
>> >> ff_shl_bidir ?
>> >
>> > shl == unsigned shift to me
>> >
>>
>> Then i don't see anything better than yours.
> [...]
>> +static inline int ff_bidir_sal(int value, int offset)
>
> as this is static it actually doesnt need the ff_ prefix
>
> and patch ok besides this.
>

Applied without "ff_" prefix.


-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719