[FFmpeg-devel] [PATCH] Use pkg-config for libschroedinger libs
Mon May 12 19:19:08 CEST 2008
On Mon, 2008-05-12 at 18:32 +0200, Reimar D?ffinger wrote:
> On Mon, May 12, 2008 at 05:13:04PM +0100, Ramiro Polla wrote:
> > >>>> also pkg-config is used in the line above for cflags,
> > > That's irrelevant. As long as pkg-config isn't mandated by
> > > POSIX, we should assume it might not be there.
> > We should get rid of memalign() too. After all, it's not POSIX...
> Huh? FFmpeg already works without memalign. And there is even a hack
> that allows even the assembler optimizations to work without it.
And posix_memalign is POSIX.
> So to me it seems your example actually confirms Mans' opinion?
IMO M?ns is wrong. libschroedinger is not a part of POSIX and using its
API requires the presence of additional files beyond POSIX in any case.
If that includes not only .h files but also .pc files and pkg-config
there's nothing wrong with that.
> Also I think there is no problem to _also_ try pkg-config, but depending
> on it really is not a great thing
How would you try without using pkg-config? Anything better than "let's
try these flags, they worked with one version I tested with"? (I suppose
that's basically what the current code is.)
> - also as it encourages projects using
> pkg-config to do sloppy dependency-managment.
Any dependency changes without pkg-config are clumsy to do and likely to
cause lots of breakage. IMO it's not really fair to call making them
easier "encouraging sloppy dependency management" even if it does
increase the likelihood of someone making changes unnecessarily.
> And for what it's worth, libdirac/schrodinger to me are the typical
> examples that really have no reason at all to _need_ pkg-config.
Maybe they could do without, but IMO it's a good thing if libraries move
towards standardized pkg-config usage.
More information about the ffmpeg-devel